Add backward imputations for lifetime income #228
Closed
justin-ven wants to merge 32 commits into
Closed
Conversation
Collaborator
|
It's working! 👍 |
| private static Map<String, Object> collectorArgs; | ||
| private static Map<String, Object> parameterArgs; | ||
| public static String configFile = "default.yml"; | ||
| public static String configFile = "test_run.yml"; |
Collaborator
There was a problem hiding this comment.
It might not matter, but would suggest leaving this as 'default.yml' in the standard files? The github integration tests use 'test_run.yml' as given explicitly as an argument. This would default all further users to the test config file if no argument were given. I think a major difference is that the test one doesn't persist Persons/Households/BenefitUnits csv files (as not required by tests), so new users may be puzzled where these go?
Comment on lines
+163
to
+169
| <dependency> | ||
| <groupId>org.apache.logging.log4j</groupId> | ||
| <artifactId>log4j-api</artifactId> | ||
| <version>2.17.2</version> | ||
| <scope>compile</scope> | ||
| </dependency> | ||
| </dependencies> |
Collaborator
There was a problem hiding this comment.
as a quick check - this seems to be repeating the log4j import from a few lines above but updating version?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functionality to impute lifetime incomes by imputing annual incomes prior to the reference population cross-section. Pull request also includes some bug fixes - see for example the new checkFinite method on the Parameters object.